Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apache commons-lang3 dependency in Server. #3102

Closed
8 tasks done
KomachiSion opened this issue Jun 18, 2020 · 8 comments
Closed
8 tasks done

Remove apache commons-lang3 dependency in Server. #3102

KomachiSion opened this issue Jun 18, 2020 · 8 comments
Labels
contribution welcome dependencies Pull requests that update a dependency file kind/refactor
Milestone
2.0.3

Comments

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jun 18, 2020 •
edited

Issue Description

Type: Remove dependency

Describe what happened (or what feature you want)

Nacos wants to reduce the dependency to reduce size of server. And the community volunteers wants to remove commons-lang3 first. So I create an issue and split tasks for community.

Describe what you expected to happen

Replace commons-lang3 dependency module by module. And the behavior of server do not change.

How to reproduce it (as minimally and precisely as possible)

  • Create utils class to nacos-common or nacos-api module.
  • Replace commons-lang3 in nacos-common module.
  • Replace commons-lang3 in nacos-core module.
  • Replace commons-lang3 in nacos-config module.
  • Replace commons-lang3 in nacos-naming module.
  • Replace commons-lang3 in nacos-console module.
  • Replace commons-lang3 in other modules(if necessary, will be spiltted again).
  • remove commons-lang3 pom dependency.

Welcome volunteer join us.
@KomachiSion KomachiSion added contribution welcome dependencies Pull requests that update a dependency file labels Jun 18, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Jun 18, 2020
@KomachiSion KomachiSion mentioned this issue Jun 18, 2020
Closed
5 tasks
@zongtanghu
Copy link
Collaborator

[] Create utils class to nacos-common or nacos-core module.
[] Replace commons-lang3 in nacos-common module.
[] Replace commons-lang3 in nacos-core module.
[] Replace commons-lang3 in nacos-config module.
[] Replace commons-lang3 in nacos-naming module.
[] Replace commons-lang3 in nacos-console module.
[] Replace commons-lang3 in other modules(if necessary, will be spiltted again).
[] remove commons-lang3 pom dependency.

Then, we claim this feature issue? @KomachiSion

@KomachiSion
Copy link
Collaborator Author

@zongtanghu you can create an issue according these unfinished task. and refer to this issue.

Of course, you can also directly open PR to finished task one by one.

This was referenced Jun 18, 2020
Closed
Merged
@wangweizZZ
Copy link
Collaborator

@lin-mt @zongtanghu hi，is this part of work still in progress? Maybe @corey89757 can help solve this problem together :-)

@shizhengxing
Copy link
Contributor

I‘d like to work this out together

@KomachiSion KomachiSion modified the milestones: 1.4.0, 1.4.1 Sep 22, 2020
@horizonzy horizonzy mentioned this issue Oct 18, 2020
Closed
@corey89757
Copy link
Contributor

I am working on it.

corey89757 added a commit to corey89757/nacos that referenced this issue Nov 5, 2020
@corey89757
[ISSUE alibaba#3102] remove org.apache.common.lang and org.apache.com…
54c7799 
…mon.lang3 in api,client and common module.

Change-Id: I3a1d70f9e5ad8e2ce76868c8f2e6f954c0faad81
@corey89757 corey89757 mentioned this issue Nov 5, 2020
Closed
5 tasks
@corey89757
Copy link
Contributor

I'll split the pr and optimise some details.

corey89757 added a commit to corey89757/nacos that referenced this issue Nov 7, 2020
@corey89757
[ISSUE alibaba#3102] Create utils class to nacos-common.
01d6fe1 
Change-Id: I30970371b86a032366bd66c7b031a4cc3085512e
corey89757 added a commit to corey89757/nacos that referenced this issue Nov 7, 2020
@corey89757
[ISSUE alibaba#3102] Create utils class to nacos-common, fix check st…
5684d9f 
…yle errors.

Change-Id: I4711ad2b64a4265379f5d7df7434352e69c3760d
@corey89757 corey89757 mentioned this issue Nov 7, 2020
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Nov 9, 2020
@corey89757
[ISSUE #3102] Create utils class to nacos-common (#4165)
cf92d19 
* [ISSUE #3102] Create utils class to nacos-common.

Change-Id: I30970371b86a032366bd66c7b031a4cc3085512e

* [ISSUE #3102] Create utils class to nacos-common, fix check style errors.

Change-Id: I4711ad2b64a4265379f5d7df7434352e69c3760d
KomachiSion added a commit that referenced this issue Nov 10, 2020
@KomachiSion
Revert "[ISSUE #3102] Create utils class to nacos-common (#4165)"
b5ce686 
This reverts commit cf92d19.
KeRan213539 pushed a commit that referenced this issue Nov 10, 2020
@KomachiSion
Revert "[ISSUE #3102] Create utils class to nacos-common (#4165)" (#4191
8950304 
)

This reverts commit cf92d19.
corey89757 pushed a commit to corey89757/nacos that referenced this issue Nov 11, 2020
[ISSUE alibaba#3102] add commons-lang3 dependency into core and sys, …
f95931d 
…prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: I7c7d39991b97be9c505a66ce013de0166487e74b
@corey89757 corey89757 mentioned this issue Nov 11, 2020
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Nov 11, 2020
@corey89757
[ISSUE #3102] remove lang dependency. (#4202)
3e33851 
* add commons-lang3 dependency into core and sys, prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: I4b7a0bec09359e64ecf997b123b85c265bfe16cf

* remove lang dependency.

Change-Id: I5cbd811babc8269a54b93e278ad6e5e2663c8427
@corey89757 corey89757 mentioned this issue Nov 12, 2020
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Nov 12, 2020
@corey89757
[ISSUE #3102] remove lang/lang3 dependency from api/common/client. (#…
01101c5 
…4207)

* add commons-lang3 dependency into core and sys, prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: I4b7a0bec09359e64ecf997b123b85c265bfe16cf

* remove lang dependency.

Change-Id: I5cbd811babc8269a54b93e278ad6e5e2663c8427

* remove lang/lang3 dependency from api/common/client.

Change-Id: I77b5cf5d922a7c031fa4676d1404de7cb255a010
@corey89757
Copy link
Contributor

Since now, there isn't any lang dependency in common/api/client module.

@li-xiao-shuang
Copy link
Collaborator

Has the problem been dealt with yet

ZZQ001010 added a commit to ZZQ001010/nacos that referenced this issue Jun 26, 2021
@ZZQ001010
[ISSUE alibaba#3102] Remove apache commons-lang3 dependency in nacos
8ceb256
@ZZQ001010 ZZQ001010 mentioned this issue Jun 26, 2021
Closed
ZZQ001010 added a commit to ZZQ001010/nacos that referenced this issue Jun 28, 2021
@ZZQ001010
[ISSUE alibaba#3102 common] add ArrayUtils、ArrayUtilsTest
5ee509f
@ZZQ001010 ZZQ001010 mentioned this issue Jun 28, 2021
Closed
9 tasks
ZZQ001010 added a commit to ZZQ001010/nacos that referenced this issue Jun 28, 2021
@ZZQ001010
[ISSUE alibaba#3102 common] format test class
9540a82
@KomachiSion KomachiSion mentioned this issue Jun 30, 2021
Closed
This was referenced Jun 30, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 7, 2021
Closed
Closed
Closed
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 13, 2021
@KomachiSion KomachiSion mentioned this issue Jul 21, 2021
Closed
@snyk-bot snyk-bot mentioned this issue Dec 8, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome dependencies Pull requests that update a dependency file kind/refactor
Projects
None yet
Milestone
2.0.3
Development

No branches or pull requests
6 participants
@zongtanghu @wangweizZZ @corey89757 @shizhengxing @li-xiao-shuang @KomachiSion