Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw Inside Finally #4596

Closed
QiAnXinCodeSafe opened this issue Dec 29, 2020 · 0 comments · Fixed by #4606
Closed

Throw Inside Finally #4596

QiAnXinCodeSafe opened this issue Dec 29, 2020 · 0 comments · Fixed by #4606
Assignees
@Maijh97
Labels
kind/code quality

Comments

@QiAnXinCodeSafe
Copy link

QiAnXinCodeSafe commented Dec 29, 2020 •
edited

Any exceptions thrown from the try or catch segment are eliminated when an exception is thrown ina finally block

nacos/client/src/main/java/com/alibaba/nacos/client/naming/cache/ConcurrentDiskUtil.java

Lines 85 to 94 in 00d4363

} finally {
if (rlock != null) {
rlock.release();
rlock = null;
}
if (fis != null) {
fis.close();
fis = null;
}
}

nacos/client/src/main/java/com/alibaba/nacos/client/config/utils/ConcurrentDiskUtil.java

Lines 86 to 95 in 00d4363

} finally {
if (rlock != null) {
rlock.release();
rlock = null;
}
if (fis != null) {
fis.close();
fis = null;
}
}

nacos/config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigServletInner.java

Lines 277 to 282 in 00d4363

} finally {
releaseConfigReadLock(groupKey);
if (null != fis) {
fis.close();
}
}

nacos/common/src/main/java/com/alibaba/nacos/common/utils/IoUtils.java

Lines 65 to 72 in 00d4363

} finally {
if (out != null) {
out.close();
}
if (gis != null) {
gis.close();
}
}

nacos/common/src/main/java/com/alibaba/nacos/common/utils/IoUtils.java

Lines 96 to 103 in 00d4363

} finally {
if (out != null) {
out.close();
}
if (gis != null) {
gis.close();
}
}

nacos/common/src/main/java/com/alibaba/nacos/common/utils/IoUtils.java

Lines 124 to 128 in 00d4363

} finally {
if (null != os) {
os.close();
}
}

nacos/common/src/main/java/com/alibaba/nacos/common/utils/IoUtils.java

Lines 313 to 320 in 00d4363

} finally {
if (null != sc) {
sc.close();
}
if (null != tc) {
tc.close();
}
}

nacos/config/src/main/java/com/alibaba/nacos/config/server/service/datasource/LocalDataSourceServiceImpl.java

Lines 237 to 241 in 00d4363

} finally {
if (sqlFileIn != null) {
sqlFileIn.close();
}
}

nacos/config/src/main/java/com/alibaba/nacos/config/server/service/datasource/LocalDataSourceServiceImpl.java

Lines 263 to 267 in 00d4363

} finally {
if (stmt != null) {
stmt.close();
}
}

nacos/common/src/main/java/com/alibaba/nacos/common/http/client/NacosRestTemplate.java

Lines 484 to 488 in 00d4363

} finally {
if (response != null) {
response.close();
}
}

nacos/naming/src/main/java/com/alibaba/nacos/naming/consistency/persistent/raft/RaftStore.java

Lines 276 to 280 in 00d4363

} finally {
if (fc != null) {
fc.close();
}
}

@Maijh97 Maijh97 self-assigned this Dec 30, 2020
@Maijh97 Maijh97 mentioned this issue Dec 30, 2020
Merged
5 tasks
@Maijh97 Maijh97 linked a pull request Dec 30, 2020 that will close this issue
[ISSUE-#4594,#4596] Fix IO close problem #4606
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maijh97 Maijh97

Labels
kind/code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE-#4594,#4596] Fix IO close problem Maijh97/nacos
2 participants
@Maijh97 @QiAnXinCodeSafe