Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] When use nacosDomain mode in namingProxy, didn't use servers to retry. #4662

Closed
horizonzy opened this issue Jan 10, 2021 · 0 comments
Assignees
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@horizonzy
Copy link
Collaborator

horizonzy commented Jan 10, 2021

Describe the bug
Now in namingProxy, in the method reqApi.
It will judge is nacosDomain mode, the nacosDoamin is from when serverList's == 1.
If nacosDomain mode, it will retry maxRetry times to callServer. If all failed, then will use servers mode to callServer. In fact, it will retry maxRetry + 1 times.

Expected behavior
Just choose one between nacosDomain mode and servers mode.

@horizonzy horizonzy self-assigned this Jan 10, 2021
@horizonzy horizonzy added the kind/enhancement Category issues or prs related to enhancement. label Jan 10, 2021
horizonzy added a commit that referenced this issue Jan 11, 2021
[ISSUE-#4662] Just choose one between nacosDomain mode and servers mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant