New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STORM-935] Update Disruptor queue version to 2.10.4 #630
Conversation
…se waitfor method without timeout
+1 @errordaiwa how is the cpu usage with high bolt count when idle ? |
@errordaiwa @arunmahadevan In short, applying both configuring timeout and upgrading Disruptor to 2.10.4 makes sense for me. @errordaiwa |
@HeartSaVioR @arunmahadevan I do a performance test using storm 0.9.3 with disruptor queue 2.10.4. The target topology is metioned in STORM-503. To make result more clear, I raise bolt num to 1000. Here is the CPU usage.
|
@errordaiwa @amontalenti We're having a option to set timeout now, so it would be no issue. |
I am fine with whichever timeout we pick. I am +1 for merging this in pending the results of the tests @HeartSaVioR is running. |
@revans2 Thanks for confirming. :) During running performance test I can't see any failed tuples from the UI in 10 minutes, so I think it is safe to merge. Btw, it would be better for users to change default timeout in order to let users not suffering STORM-503 with default setting. @errordaiwa Could you change default timeout to 1000ms? After changing default timeout I'll merge. |
done. @HeartSaVioR @revans2 Thanks for validation and confirming. |
+1. |
Since many users are already affected this situation, it should be included to 0.9.x line. |
It is merged to master, and I'm working on backport to 0.10.x and 0.9.x. |
I merged this into 0.10.x-branch and 0.9.x-branch by cherry-picked. Since there're different available sets of config validators among branches - master, 0.10.x, 0.9.x, I take the best proper validator to each branch.
|
Great! @HeartSaVioR Sincerely thank you for working on this! |
Update version of Disruptor queue to 2.10.4, consumer of queue will use waitfor method without timeout. Test on storm 0.9.3, works fine.