Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add regex to assert.throws in test-vm-run-in-new-context #11815

Closed
wants to merge 1 commit into from
Closed

test: add regex to assert.throws in test-vm-run-in-new-context #11815

wants to merge 1 commit into from

Conversation

matejkrajcovic
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@matejkrajcovic
test: add regex to assert.throws
2e10483 
Make sure test matches this specific error message.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 12, 2017
@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Mar 12, 2017
@mscdex
Copy link
Contributor

mscdex commented Mar 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6811/

jasnell pushed a commit that referenced this pull request Mar 15, 2017
@matejkrajcovic @jasnell
test: add regex to assert.throws
2281944 
Make sure test matches this specific error message.

PR-URL: #11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 15, 2017

Landed in 2281944

@jasnell jasnell closed this Mar 15, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@matejkrajcovic @italoacasas
test: add regex to assert.throws
c9cf922 
Make sure test matches this specific error message.

PR-URL: nodejs#11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@matejkrajcovic @jungx098
test: add regex to assert.throws
39e47f6 
Make sure test matches this specific error message.

PR-URL: nodejs#11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@matejkrajcovic @MylesBorins
test: add regex to assert.throws
bde2f16 
Make sure test matches this specific error message.

PR-URL: #11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@matejkrajcovic @MylesBorins
test: add regex to assert.throws
a3f327f 
Make sure test matches this specific error message.

PR-URL: #11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
@matejkrajcovic matejkrajcovic deleted the fix-test branch May 7, 2017 20:56
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@matejkrajcovic @andrew749
test: add regex to assert.throws
c521c1a 
Make sure test matches this specific error message.

PR-URL: nodejs/node#11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@matejkrajcovic @mscdex @jasnell @addaleax @lpinca @cjihrig @hiroppy @MylesBorins @nodejs-github-bot