doc: gcc version is at least 4.8.5 at BUILDING.md #11840

detailyang · 2017-03-14T09:16:54Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

This PR is inspired by #10388 when I try to compile the node v6.x with gcc 4.8.0 :(. I check the prerequisites at BUILDING.md and It tell me that gcc version at least is 4.8.0 which is actually out of date (Aslo a typo about or).

bnoordhuis · 2017-03-14T09:58:54Z

First commit LGTM, thanks. The , or is not a typo though, it's to signal that you need either g++ x.y.z OR clang++ x.y.

detailyang · 2017-03-14T12:17:51Z

Hello.
@bnoordhuis gotcha! Many Thanks :D

The latest version of 4.8 available for 12.04 is 4.8.4. It is not able to build V8 from version 5.7 and does not satisfy the requirements to build Node.js. Refs: nodejs/node#11840 Refs: nodejs/v8#5

cjihrig

LGTM, but I see some discussion about requiring 4.9 in other issues.

bnoordhuis · 2017-03-14T14:34:01Z

We'll probably drop g++ 4.8 for node 8.0. Bumping the baseline from 4.8.0 to 4.8.5 for <= v7.x is a good idea, though.

bnoordhuis

LGTM. Can you mention in the commit log that the bump is because of compiler bugs in g++ < 4.8.5?

detailyang · 2017-03-14T14:50:34Z

No Problem. I will do rebase these commits to one commit after cloning this huge repo slowly because of Chinese GFW :(

bnoordhuis · 2017-03-14T15:11:31Z

Oh, I suppose that whoever merges this can amend the commit log.

bumping the baseline from gcc 4.8.0 to gcc 4.8.5 because of compiler bugs in g++ < 4.8.5.

…ch-1

detailyang · 2017-03-14T16:22:27Z

It looks like cannot rebase the PR which have already issued without git push --force (sorry, my fault). Maybe some people can squashing these commits when merging and mention what @bnoordhuis said

bumping the baseline from gcc 4.8.0 to gcc 4.8.5 because of compiler bugs in g++ < 4.8.5.

Many Thanks :D

detailyang · 2017-03-15T03:02:05Z

BTW, 4.8.5 is a good interim version IMO since the centos:7 is using the 4.8.0 as the system default version and other system like fedora:latest 、debian:lastest and ubuntu:latest is at least 4.9.0.

>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: #11840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2017-03-16T22:26:32Z

Landed in 746339e with amended commit log per @bnoordhuis' request

>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: nodejs#11840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2017-04-18T17:15:07Z

is this also accurate for v6.x?

gibfahn · 2017-04-18T19:04:01Z

is this also accurate for v6.x?

Based on:

This PR is inspired by #10388 when I try to compile the node v6.x with gcc 4.8.0

I'd say so.

>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: #11840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

pmq20 · 2017-06-05T06:55:08Z

4.8.2 works fine on my old Linux box. Why do we have to make it 5? #13462

gibfahn · 2017-06-05T07:06:12Z

We'll probably drop g++ 4.8 for node 8.0. Bumping the baseline from 4.8.0 to 4.8.5 for <= v7.x is a good idea, though.

@bnoordhuis I note that this never happened, do you know if it needs to (i.e. will 4.8.5 be okay for the lifetime of v8.x)?

bnoordhuis · 2017-06-05T08:49:51Z

@gibfahn C++11 support is not 100% functional in 4.8.x. Updating the requirements is still a good idea, IMO; we don't want to be hampered by compiler bugs. I'll file a pull request.

The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. Refs: nodejs#11840

The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>

The latest version of 4.8 available for 12.04 is 4.8.4. It is not able to build V8 from version 5.7 and does not satisfy the requirements to build Node.js. Refs: nodejs/node#11840 Refs: nodejs/v8#5

The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>

>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: nodejs/node#11840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

detailyang added 2 commits March 14, 2017 17:07

doc: gcc version is at least 4.8.5 in BUILDING.md

a68139e

doc: typo at BUILDING.md

99a18a1

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2017

doc: revert remove , or

fbaa06c

This was referenced Mar 14, 2017

ubuntu: bump gcc to 4.9 on 12.04 nodejs/build#650

Closed

Build failure on Ubuntu 12.04 with 5.7-lkgr nodejs/v8#5

Closed

cjihrig approved these changes Mar 14, 2017

View reviewed changes

bnoordhuis approved these changes Mar 14, 2017

View reviewed changes

detailyang added 2 commits March 15, 2017 00:16

doc: gcc version is at least 4.8.5 in BUILDING.md

e585938

bumping the baseline from gcc 4.8.0 to gcc 4.8.5 because of compiler bugs in g++ < 4.8.5.

Merge branch 'patch-1' of https://github.com/detailyang/node into pat…

ef12fae

…ch-1

lpinca approved these changes Mar 15, 2017

View reviewed changes

jasnell approved these changes Mar 15, 2017

View reviewed changes

bnoordhuis mentioned this pull request Mar 16, 2017

doc: add supported platforms list #11872

Closed

3 tasks

jasnell closed this Mar 16, 2017

italoacasas mentioned this pull request Mar 20, 2017

v7.7.4 Release Proposal #11941

Merged

MylesBorins added the lts-watch-v6.x label Apr 18, 2017

MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels May 8, 2017

MylesBorins mentioned this pull request May 23, 2017

v6.11.0 proposal #13059

Merged

bnoordhuis mentioned this pull request Jun 5, 2017

doc: update minimum g++ version to 4.9.4 #13466

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: gcc version is at least 4.8.5 at BUILDING.md #11840

doc: gcc version is at least 4.8.5 at BUILDING.md #11840

detailyang commented Mar 14, 2017 •

edited

bnoordhuis commented Mar 14, 2017

detailyang commented Mar 14, 2017

cjihrig left a comment

bnoordhuis commented Mar 14, 2017

bnoordhuis left a comment

detailyang commented Mar 14, 2017

bnoordhuis commented Mar 14, 2017

detailyang commented Mar 14, 2017 •

edited

detailyang commented Mar 15, 2017

jasnell commented Mar 16, 2017

MylesBorins commented Apr 18, 2017

gibfahn commented Apr 18, 2017 •

edited

pmq20 commented Jun 5, 2017

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

doc: gcc version is at least 4.8.5 at BUILDING.md #11840

doc: gcc version is at least 4.8.5 at BUILDING.md #11840

Conversation

detailyang commented Mar 14, 2017 • edited

Checklist

Affected core subsystem(s)

bnoordhuis commented Mar 14, 2017

detailyang commented Mar 14, 2017

cjihrig left a comment

Choose a reason for hiding this comment

bnoordhuis commented Mar 14, 2017

bnoordhuis left a comment

Choose a reason for hiding this comment

detailyang commented Mar 14, 2017

bnoordhuis commented Mar 14, 2017

detailyang commented Mar 14, 2017 • edited

detailyang commented Mar 15, 2017

jasnell commented Mar 16, 2017

MylesBorins commented Apr 18, 2017

gibfahn commented Apr 18, 2017 • edited

pmq20 commented Jun 5, 2017

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

detailyang commented Mar 14, 2017 •

edited

detailyang commented Mar 14, 2017 •

edited

gibfahn commented Apr 18, 2017 •

edited