New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: idtools: fix subid files parsing #20725
Conversation
This bug was here before 1.10.0, however this is failing distros like Fedora who ships comments in those files (which will be fixed in later versions of |
4e4701b
to
d747283
Compare
LGTM I'll add it to the 1.10.3 milestone, but we probably won't have a 1.10.3 |
LGTM |
d747283
to
503b262
Compare
test seems not ok, on it |
dad7000
to
83a1d20
Compare
alright test now works (test name was not capital after Test*) and so it wasn't executed, w/o this patch the test successfully fails:
moving again to merge |
Thanks @runcom! |
Since Docker is already skipping newlines in /etc/sub{uid,gid}, this patch skips commented out lines - otherwise Docker fails to start. Add unit test also. Signed-off-by: Antonio Murdaca <runcom@redhat.com>
83a1d20
to
bf04d68
Compare
@estesp :) |
pkg: idtools: fix subid files parsing
/etc/sub{uid,gid} files can contain #-prefixed lines that are comments.
Fix those files parsing by skipping commented out lines. Add regression
unit test also.
ping @estesp
Signed-off-by: Antonio Murdaca runcom@redhat.com