Close resp body on plugin call error #20680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
LGTM. Since the whole body has been read, I don't see any reason not to close it right then and there. Forgetting to close response bodys in error conditions has to be one of the most common errors of all time. It is the same as forgetting to kitty is SO ANGRY. |
|
LGTM 🐯 |
vdemeester
added a commit
that referenced
this pull request
Feb 25, 2016
Close resp body on plugin call error
|
@cpuguy83 candidate for a patch release? (if we have one?) |
|
@thaJeztah makes sense, though not strictly a horrible issue unless there is a misbehaving plugin. |
cpuguy83
added
the
priority/P3
thaJeztah
removed
the
priority/P3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following information:
Fix an issue with the plugin system leaking fd's when the plugin has an error
Make sure the resp body is closed on error