Fix panic when plugin responds with null volume #20682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the a plugin responds with both a null or empty volume and a null or empty Err, the daemon would panic. This is because we assumed the idiom if `err` is nil, then `v` must not be but in reality the plugin may return whatever it wants and we want to make sure it doesn't harm the daemon. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
LGTM |
|
LGTM 🐿 |
vdemeester
added
status/4-merge
status/5-cherry-pick
and removed
status/2-code-review
labels
vdemeester
added a commit
that referenced
this pull request
Feb 25, 2016
Fix panic when plugin responds with null volume
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following information:
Fix panic when volume plugin returns a null response for
GetrequestsCheck for a
nildecoded volume.See
TestExternalVolumeDriverGetEmptyResponseIn cases where the a plugin responds with both a null or empty volume
and a null or empty Err, the daemon would panic.
This is because we assumed the idiom if
erris nil, thenvmust notbe but in reality the plugin may return whatever it wants and we want to
make sure it doesn't harm the daemon.
Fixes #20952