Fix custom terminal directive with global mixin #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -627,7 +628,8 @@ function makeTerminalNodeLinkFn (el, dirName, value, options, def) { | |||
| filters: parsed.filters, | |||
| raw: value, | |||
| // either an element directive, or if/for | |||
| def: def || publicDirectives[dirName] | |||
| // #2366 or custom terminal directive | |||
| def: def || publicDirectives[dirName] || Vue.options.directives[dirName] | |||
There was a problem hiding this comment.
Thanks, this should actually be def || resolveAsset(options, 'directives', dirName) so that:
- We don't need to import
Vuehere (feels dirty) - We reuse the same asset resolution logic (auto warnings if no directive found)
rhyzx
force-pushed
the
fix-terminal-directives-with-global-mixin
branch
from
629fe67
to
97b82f8
Compare
yyx990803
added a commit
that referenced
this pull request
Feb 20, 2016
…al-mixin Fix custom terminal directive with global mixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo: https://jsfiddle.net/rhyzx/qdyq4z7z/2/
This is because Vue will replace old options with new one instead of extending exist options when
mixin(), so compiler will get an outdated reference of directives definition object.