Scheduler Performance Testing #18458
Conversation
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
/cc @lavalamp This extends your original work in integration test. |
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
hongchaodeng
force-pushed
the
perf
branch
3 times, most recently
from
110fb07
to
a4f9b7f
Compare
|
general comments before review. Is there a reason why you chose performance vs. component as we talked about in the sig. Also please squash commits. |
| How To Run | ||
| ------ | ||
| ``` | ||
| cd kubernetes/test/performance/scheduler |
There was a problem hiding this comment.
should have a kicker script from ./hack to follow all the existing patterns.
There was a problem hiding this comment.
I am keeping this standalone for now and seeking discussion here :)
How to better integrate it with k8s overall structure and ensure it won't be broken in future PRs?
|
@timothysc , Thanks for the comments.
I clean up the commits before submitting it. All commits do one thing specifically.
That's easy to change. @davidopp links all these to "perf" issues. IMHO, "performance" sounds closer to what we are doing. We came up with "component" sort of hurried. Let's keep it open and collect opinions from all folks. |
|
@hongchaodeng |
|
|
||
| Future Work | ||
| ------ | ||
| A list of some future work: |
There was a problem hiding this comment.
for this readme I don't think you need to add future work, as it just outlines the tests. It's not a proposal.
|
If we add correctness testing here, how could we separate it from integration test? |
|
benchmarks/performance could be one aspect of component testing. |
|
I agree that we can change naming from "performance" to "component". |
|
sgtm. |
hongchaodeng
force-pushed
the
perf
branch
6 times, most recently
from
23c406e
to
55a4308
Compare
|
@kubernetes/sig-scalability someone here is probably better equipped to review this than I |
|
The test suite relies on running etcd instance on |
|
GCE e2e test build/test passed for commit e3da7703b07307b60d131cf60ac63718b2c4d6e9. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
@hongchaodeng - please squash the commits |
|
GCE e2e build/test failed for commit cf3505a7befb6c2ca94780d5721d3920e5a07766. |
|
GCE e2e test build/test passed for commit 9704222. |
|
@wojtek-t |
|
LGTM |
wojtek-t
added
the
lgtm
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
GCE e2e build/test failed for commit 9704222. |
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit 9704222. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 9704222. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
|
/cc @sttts |
This resolves #18091.
The work currently is separate and standalone. I want to ask some questions w.r.t. existing dev flow:
hackand also can compile these code inbuild.