Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathjax load from cdn makes Piggydb unusable without internet connetction #9

Closed
corvus-ch opened this issue Jul 9, 2014 · 3 comments

Comments

@corvus-ch
Copy link

The Mathjax JS library is loaded via CDN. This makes Piggydb (6.18-supporters) unusable without a connection to the internet.

I suggest to either include Mathjax to the package or check if it is loaded before using it.

GET http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_HTML net::ERR_INTERNET_DISCONNECTED fragment.htm:60
Uncaught ReferenceError: MathJax is not defined piggydb.widget.Fragment.js?6.18-supporters:41
Uncaught ReferenceError: MathJax is not defined piggydb.widget.Fragment.js?6.18-supporters:38
@marubinotto
Copy link
Owner

I think Mathjax is too heavy to be included in the package, so it would be better to provide an option to disable it.

@corvus-ch
Copy link
Author

I do not see that argument. Sure Mathjax would add over 32MB to the package bot not doing so would prevent using its functionality when offline.

As I see it, the only valid reason to not add it, are legal ones (e.g. license miss match).

@marubinotto
Copy link
Owner

Fixed by including MathJax in the package. Will be released in v7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants