Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

the enter key does not work correctly on the new filter tool-bar IE 11 #114

Closed
Gsantomaggio opened this issue Jan 22, 2016 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@Gsantomaggio
Copy link
Member

When apply a filter for example by name and press enter the filter is not applied, seems does not call the pagination api.

This error occurs only using IE ( I tested on version 11 )

@Gsantomaggio Gsantomaggio self-assigned this Jan 22, 2016
@Gsantomaggio
Copy link
Member Author

Yes, it is a bug, this function https://github.com/rabbitmq/rabbitmq-management/blob/rabbitmq-management-50/priv/www/js/main.js#L642 it is not raised on IE11.

I changed it with this:
function postprocess_partial() {
$('.pagination_class').keypress(function(e) {
if (e.keyCode == 13) {
update_pages(current_template, !!$(this).attr('data-page-start') ? $(this).attr('data-page-start') : $(this).val());
}
});

now seems work correctly. I will made a few tests

@michaelklishin michaelklishin added this to the 3.6.1 milestone Jan 25, 2016
@michaelklishin
Copy link
Member

Please submit a PR and I will test it in other browsers and on OS X/Linux some more.

@Gsantomaggio
Copy link
Member Author

Thank you @michaelklishin ! I did also a few tests also using Opera 34.0.2036.50 on Windows 7

@michaelklishin
Copy link
Member

Fixed in #115.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants