tools: monstore: add 'show-versions' command. #7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you take a look and merge it ?@jecluis |
Closed
dllgzcl
force-pushed
the
wip-zcl-show-version
branch
from
eddfc09
to
c36cc66
Compare
dllgzcl
changed the title
| po::options_description op_desc("Allowed 'show-versions' options"); | ||
| op_desc.add_options() | ||
| ("help,h", "produce this help message") | ||
| ("map-type",po::value<string>(&map_type),"map_type"); |
There was a problem hiding this comment.
add a space after the comma ",",
Using this tool, the first/last committed version of maps will be shown. Signed-off-by: Cilang Zhao <zhao.cilang@h3c.com>
dllgzcl
force-pushed
the
wip-zcl-show-version
branch
from
c36cc66
to
21e6ba0
Compare
|
I've tested this and it works in its current form. I noticed two things I think you should consider addressing on a later pull request though:
Anyway, I'll take it. :) Thanks! |
jecluis
added a commit
that referenced
this pull request
Jan 7, 2016
tools: monstore: add 'show-versions' command. Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this tool, we can list the first/last committed version of maps.
Signed-off-by: Cilang Zhao zhao.cilang@h3c.com