tools: ceph_monstore_tool: add inflate-pgmap command #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this command repeatly add the latest pgmap to the monstore in order to inflate it. the command helps with the testing of some monstore related performance issue of monitor Fixes: ceph#14217 Signed-off-by: Kefu Chai <kchai@redhat.com>
| ps != pg_stat.end(); ++ps) { | ||
| ::encode(ps->first, dirty_pgs); | ||
| if (!can_be_trimmed) { | ||
| ps->second.last_epoch_clean = first; |
There was a problem hiding this comment.
Need one more whitespace here:-)
There was a problem hiding this comment.
it's a tab. and per https://github.com/ceph/ceph/blob/master/CodingStyle#L76, we use tab-width = 8, so it's looks fine if your editor understands the command at the first line.
|
Understood. Thank you for your guide 👍 |
liewegas
added a commit
that referenced
this pull request
Jan 13, 2016
tools: ceph_monstore_tool: add inflate-pgmap command Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this command repeatly add the latest pgmap to the monstore in order
to inflate it. the command helps with the testing of some monstore
related performance issue of monitor
Fixes: #14217
Signed-off-by: Kefu Chai kchai@redhat.com