test/librbd/fsx: Use c++11 std::mt19937 generator instead of random_r() #6332
Conversation
Signed-off-by: John Coyle <dx9err@gmail.com>
dx9
changed the title
|
@liewegas this is another one of the Alpine PRs. I'm not sure if this code requires the (multi-threading safe) random_r or not... |
|
random_r was added on purpose, to make sure fsx failures can actually be reproduced, see abdb168. IIRC the issue was librados stealing random numbers from fsx, in particular when running with ms_inject_socket_failures enabled. Since of the two it is fsx that cares about reproducible sequences, I went for a private context within fsx. |
|
@idryomov What do you think about using a boost RNG? |
|
@dx9 Back then fsx was a C file, but now it's actually a .cc compiled with a C++ compiler, so if it helps your project, I'd fine with boost (c++11 random would be even better). As long you carefully test your change - we only look at fsx when something else had already failed... |
|
@idryomov cool, I'll look at updating the pr using c++11 random. Thanks for the feedback. I may have some more questions about how to test this properly. |
dx9
force-pushed
the
wip-12406-test_librdb_fsx
branch
from
c9c0848
to
0a6b897
Compare
dx9
changed the title
dx9
force-pushed
the
wip-12406-test_librdb_fsx
branch
from
0a6b897
to
c103fcb
Compare
| prterr("setstate_r"); | ||
| exit(1); | ||
| } | ||
| random_generator.seed(seed); | ||
|
|
…:mt19937 generator instead. Signed-off-by: John Coyle <dx9err@gmail.com>
dx9
force-pushed
the
wip-12406-test_librdb_fsx
branch
from
c103fcb
to
1df9705
Compare
|
@idryomov ping |
test/librbd/fsx: Use c++11 std::mt19937 generator instead of random_r() Improve portability - random_r() is GNU-specific. Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
ghost
changed the title
Is it possible to use random instead of random_r? random_r is a glibc extension, musl libc doesn't implement it.