rgw: Parse --subuser better #7279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a funny message "ERROR: 'tenant$user != tenant$user'" in case --subuser='tenant$user' is supplied. Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
zaitcev
force-pushed
the
wip-5073-subuser
branch
from
ee4c531
to
a51fbf2
Compare
yehudasa
added a commit
that referenced
this pull request
Jan 20, 2016
rgw: Parse --subuser better Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Woops. I meant to allow a conflict-less setting of user alongside
the --tenant option. However, since we allow --subuser="user:subuser",
it makes sense to allow --subuser="tenant$user:subuser" too. Even if
we don't we ought to guard against it, least the separator leaks into
the user name and triggers exceedingly strange error messages.
Signed-off-by: Pete Zaitcev zaitcev@redhat.com