rgw:modify command stucking when operating radosgw-admin metadata list user #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (ret == -ENOENT) { | ||
| if (truncated) | ||
| *truncated = false; | ||
| return 0; |
There was a problem hiding this comment.
shouldn't we return here -ENOENT?
|
@oritwas it should be better. Is that so?
if (ret < 0 && ret != -ENOENT)
return ret;
if (ret == -ENOENT) {
if (truncated)
*truncated = false;
return -ENOENT;
|
liupeiyang
force-pushed
the
wip_metadata_list
branch
2 times, most recently
from
0f9e486
to
2766d29
Compare
|
I have revised the commit @oritwas |
…t user When no user exists,the command stucks by operating radosgw-admin metadata list user. It seems all right now. Signed-off-by: Peiyang Liu <liu.peiyang@h3c.com>
liupeiyang
force-pushed
the
wip_metadata_list
branch
from
2766d29
to
3ef9941
Compare
oritwas
added a commit
that referenced
this pull request
Jan 6, 2016
rgw:modify command stucking when operating radosgw-admin metadata list user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when no user exists,the command stucks by operating radosgw-admin metadata list user .It seems all right now
Signed-off-by: Peiyang Liu liu.peiyang@h3c.com