rgw: fix wrong check for parse() return #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of return value from JSONParser::parse() is bool, it never returns a negative value. Signed-off-by: Dunrong Huang <dunrong.huang@eayun.com>
mathslinux
force-pushed
the
fix-parse-return
branch
from
6648a7f
to
ef0849b
Compare
|
hi, @tchaikov thank you for your review, have sent the updated patch |
The type of return value from uuid_d::parse() is bool, it never returns a negative value. Signed-off-by: Dunrong Huang <dunrong.huang@eayun.com>
mathslinux
force-pushed
the
fix-parse-return
branch
from
ef0849b
to
d6c097d
Compare
|
@mathslinux this failure is not relevant and is being addressed by #6927. |
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Jan 15, 2016
rgw: fix wrong check for parse() return Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of return value from JSONParser::parse() is bool, it never returns
a negative value.
Signed-off-by: Dunrong Huang dunrong.huang@eayun.com