rgw: add missing error code for admin op API #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From http://docs.ceph.com/docs/master/radosgw/adminops/ when provided email address exists, rgw should return EmailExists rather than UserAlreadyExists Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
From http://docs.ceph.com/docs/master/radosgw/adminops/ when provided key exists, rgw should return KeyExists rather than BucketAlreadyExists. Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
From http://docs.ceph.com/docs/master/radosgw/adminops/ when invalid secret key specified, rgw should return 400 with InvalidSecretKey Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
From http://docs.ceph.com/docs/master/radosgw/adminops/ when invalid key type specified, rgw should return InvalidKeyType. Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
|
fix #14162 |
From http://docs.ceph.com/docs/master/radosgw/adminops/ when attempt to grant invalid admin capability, rgw should return InvalidCap rather than InvalidArgument. Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
InvalidCapability is more readable Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
mathslinux
force-pushed
the
rgw-add-missing-error-code
branch
from
be2cbe1
to
41fcd87
Compare
|
@yehudasa yeah, it is more readable, and the adminops.rst should be updated. changes has been pushed, thank you for your review |
yehudasa
added a commit
that referenced
this pull request
Jan 8, 2016
rgw: add missing error code for admin op API Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From http://docs.ceph.com/docs/master/radosgw/adminops/, corresponding error code should be returned for bad request