New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: rbd order will be place in 22, when set to 0 in the config_opt #6886
Conversation
@renhwztetecs please ignore the bot failure, it is a false negative ( see http://tracker.ceph.com/issues/13986 for more information). You can reschedule a run by rebasing and repushing. |
This looks good, but needs to modify the defaults test: https://github.com/ceph/ceph/blob/master/src/test/pybind/test_rbd.py#L170 |
@renhwztetecs Did you not need to modify the test @jdurgin pointed out? |
@dillaman |
@renhwztetecs Can you just append that commit to this PR instead of opening a new PR? |
@dillaman |
I recommend that you |
While you're at it, can you set the git author field too? configure it via:
With this configuration, whenever you 'git commit -s' your signed-off-by line will be automatically added to the commit message. To change the author of your existing commits, ``git rebase -i HEAD~3` (assuming there are 3 commits you want to change), select e to edit for each commit to change, and for each commit run
|
@ jdurgin |
@dillaman |
delete rbd'order = RBD_DEFAULT_OBJ_ORDER process, when rbd'order is set to zero so,delete the default order of RBD in test_rbd.py Fixes: #14139 Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
rbd: rbd order will be place in 22, when set to 0 in the config_opt Reviewed-by: Josh Durgin <jdurgin@redhat.com>
looks good, thanks! |
rbd: rbd order will be place in 22, when set to 0 in the config_opt
Fixes: #14047
Signed-off-by: huanwen ren ren.huanwen@zte.com.cn