rbd: fix static initialization ordering issues #6978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order in which static objects in different compilation units are initialized is undefined. Use static functions as a workaround. Signed-off-by: Mykola Golub <mgolub@mirantis.com>
|
@dillaman I stepped on it when building rbd with clang under FreeBSD: actions had been initialized before Shell::s_actions was initialized, and it crashed. |
dillaman
changed the title
dillaman
pushed a commit
that referenced
this pull request
Dec 18, 2015
rbd: fix static initialization ordering issues Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order in which static objects in different compilation units are
initialized is undefined. Use static functions as a workaround.
Signed-off-by: Mykola Golub mgolub@mirantis.com