rbd: add pool name to disambiguate rbd admin socket commands #6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, could you also update the test for this (qa/workunits/rbd/test_admin_socket.sh)? |
|
@wuxiangwei please rebase and repush. |
Add the pool name for a given rbd imgae when executing rbd admin socket commands in case there are more than one images with the same name in different pools. Signed-off-by: Xiangwei Wu wuxiangwei@h3c.com
|
@dillaman i have resolved the conflict, please take a look. Thank you. |
jdurgin
added a commit
that referenced
this pull request
Dec 17, 2015
rbd: add pool name to disambiguate rbd admin socket commands Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the pool name for a given rbd imgae when executing rbd admin socket
commands in case there are more than one images with the same name in
different pools.
Signed-off-by: Xiangwei Wu wuxiangwei@h3c.com