osd: shut down if we flap too many times in a short period #6708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reopen #6615 as automatically shutdown by branch deleted |
|
A few cosmetic issue, otherwise this looks good! Thanks- |
xiaoxichen
force-pushed
the
shutdown_when_flipping
branch
from
d223c45
to
9a14ff7
Compare
|
@liewegas ,done with the cosmetic issue:) |
OSD stauts may flapping due to some hardware/network issue. Although we tried our best to self healthing but still in some case the OSD is still flipping and require admin to operate. This patch try another approach that shutdown the OSD after being marked down certain times(flapping), thus speed up the convergence of cluster. Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
|
Sorry, one last request: can you construct a simple test for this? One that runs during 'make check' is probably simplest (see test//.sh). I would start an osd, mark it down explicitly 6 times (ceph osd down N), and verify that it comes back up 5 times and then doesn't on the 6th time. Thanks! |
|
@liewegas ,sorry for the late reply, test added:) |
TEST_markdown_exceed_maxdown_count : down N+1 times within period, should be UP in first N times but DOWN in last time. TEST_markdown_boot : down exactly N times within period, should be UP for all N times. TEST_markdown_boot_exceed_time : down N+1 times but exceed the period, should be UP after the test. Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
liewegas
added a commit
that referenced
this pull request
Dec 19, 2015
osd: shut down if we flap too many times in a short period Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSD stauts may flipping due to some hardware/network issue.
Although we tried our best to self healthing but still in some case
the OSD is still flipping and require admin to operate.
This patch try another approach that shutdown the OSD after certain
times of reboot(flipping), thus speed up the convergence of cluster.
Signed-off-by: Xiaoxi Chen xiaoxi.chen@intel.com