New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: optimize the session_handle_reset function #7054
Conversation
@songbaisen you might want to address following issues first:
|
@tchaikov :Thanks for your good advice.I usually use svn in before.Now I study to use github.But not very familiar with github.In the next time i will be careful. |
@songbaisen you now have two commits in this pr. one with the wrong i'd suggest you remove the last commit by "git reset --hard HEAD^", and "git commit --amend" to revise your commit message so it looks like:
and imo, probably you can also start using a topic branch with meaningful name other than "master" for developing a bug fix or a feature. |
improve the performance of this method by pulling two loops into one Fixes: ceph#14182 Signed-off-by: songbaisen <song.baisen@zte.com.cn>
@tchaikov OK, Fix it! Thanks very very much to you! |
@tchaikov ping |
lgtm with rados qa run. |
osd: optimize the session_handle_reset function Reviewed-by: Kefu Chai <kchai@redhat.com>
OSD: refactor OSD::session_handle_reset()
improve the performance of this method by pulling two loops into one
Fixes: #14182
Signed-off-by: songbaisen song.baisen@zte.com.cn