Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: optimize the session_handle_reset function #7054

Merged
merged 1 commit into from Jan 13, 2016

Conversation

songbaisen
Copy link

OSD: refactor OSD::session_handle_reset()

improve the performance of this method by pulling two loops into one

Fixes: #14182
Signed-off-by: songbaisen song.baisen@zte.com.cn

@tchaikov
Copy link
Contributor

tchaikov commented Jan 5, 2016

@songbaisen you might want to address following issues first:

  1. remove the "merge" commit from your pull request
  2. add an appropriate prefix for the title of your commit message. in this case, "OSD: " would be good enough.
  3. add the "Fixes: rgw: fix compatible with Swift URL #14182" right before your "Signed-off-by" line in your commit message
  4. be more specific in your commit message.

@songbaisen
Copy link
Author

@tchaikov :Thanks for your good advice.I usually use svn in before.Now I study to use github.But not very familiar with github.In the next time i will be careful.

@tchaikov
Copy link
Contributor

tchaikov commented Jan 5, 2016

@songbaisen you now have two commits in this pr. one with the wrong Signed-off-by line, and lots of commits from others; the other with the the issues i put in last comment.

i'd suggest you remove the last commit by "git reset --hard HEAD^", and "git commit --amend" to revise your commit message so it looks like:

OSD: refactor OSD::session_handle_reset()

improve the performance of this method by pulling two loops into one

Fixes: #14182
Signed-off-by: songbaisen <song.baisen@zte.com.cn>

and imo, probably you can also start using a topic branch with meaningful name other than "master" for developing a bug fix or a feature.

improve the performance of this method by pulling two loops into one

Fixes: ceph#14182
Signed-off-by: songbaisen <song.baisen@zte.com.cn>
@songbaisen
Copy link
Author

@tchaikov OK, Fix it! Thanks very very much to you!

@liewegas
Copy link
Member

liewegas commented Jan 8, 2016

@tchaikov ping

@tchaikov
Copy link
Contributor

tchaikov commented Jan 8, 2016

lgtm with rados qa run.

liewegas added a commit that referenced this pull request Jan 13, 2016
osd: optimize the session_handle_reset function

Reviewed-by: Kefu Chai <kchai@redhat.com>
@liewegas liewegas merged commit 0fae66f into ceph:master Jan 13, 2016
@ghost ghost changed the title Optimization the session_handle_reset function. osd: optimize the session_handle_reset function Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants