New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: Omap small bugs adapted #6669
Conversation
@dzafman the ubuntu bot failure is the false negative we discussed yesterday. |
6221382
to
3289283
Compare
lgtm with qa run. |
lots of failures like this: 2015-11-24T07:13:26.438 INFO:tasks.ceph.osd.0.burnupi34.stderr:2015-11-24 07:13:26.435286 7fcf38a5f700 -1 osd.0 pg_epoch: 174 pg[1.1( v 132'41 (0'0,132'41] local-les=166 n=1 ec=8 les/c/f 166/166/0 165/165/50) [0,4] r=0 lpr=165 crt=116'37 lcod 128'39 mlcod 128'39 act ive+clean NIBBLEWISE] process_copy_chunk omap digest 0xffffffff != source 0x0 2015-11-24T07:13:26.438 INFO:tasks.ceph.osd.0.burnupi34.stderr:2015-11-24 07:13:26.435313 7fcf38a5f700 -1 log_channel(cluster) log [ERR] : 1.1 copy from 1/9d6feb16/burnupi3420652-49/head to 1/67141e41/burnupi3420652-47/head omap digest 0xffffffff != source 0x0 |
please run through some rados/thrash jobs via teuthology-openstack. thanks! |
needs rebase? |
5c473b9
to
2f4d3ed
Compare
2f4d3ed
to
918c4f8
Compare
@@ -2091,7 +2091,24 @@ void ECBackend::be_deep_scrub( | |||
return; | |||
} | |||
|
|||
ECUtil::HashInfoRef hinfo = get_hash_info(poid, false); | |||
//copy from get_hash_info. Because we already got xattrs, so it don't need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having second thoughts on this change. Does the performance of scrub really matter that much to complicate this code? If so, we should modify get_hash_info() to take optional xattrs so it can use that if needed and available?
49dba38
to
21b9aa8
Compare
This passed 98 out of 107 rados suite tests. The failures look like infrastructure issues. |
Reverted commits and fixes are removed and/or squashed. |
Per a pervious suggestion from Sage I'm going to do a rados/thrash run. Although I do recall that I fixed the cause of the omap digest inconsistency that was seen. |
Merge ceph-qa-suite "repair_test: Add whitelist item for new stat error message # 775" BEFORE merging this one. |
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
When set omapheader/omapvals, it alreade set FLAG_OMAP. So for remove don't set again. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
The code already check object whether exist. So it don't need call touch. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
… omap. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
21b9aa8
to
5c999b1
Compare
Testing passed (12 infrastructure failures, 69 passed 81 total) rados/thrash, before rebase which caused one commit to go away because it was fixed already. No conflicts on rebase. |
@tchaikov ready to merge I already merged the require ceph-qa-suite change that corresponds to this. |
Omap small bugs adapted Reviewed-by: Kefu Chai <kchai@redhat.com>
No description provided.