osd: Omap small bugs adapted #6669

dzafman · 2015-11-20T23:32:12Z

No description provided.

loic-bot · 2015-11-21T01:47:14Z

FAILURE: http://jenkins.ceph.dachary.org/job/ceph/9463/

ghost · 2015-11-21T08:57:40Z

@dzafman the ubuntu bot failure is the false negative we discussed yesterday.

dzafman · 2015-11-23T19:38:25Z

I updated this per code-review comments for #6046. Also, rebased again so that Jenkins make check will pass.

This has been reviewed by @tchaikov and @liewegas based on other pull request.

loic-bot · 2015-11-23T20:32:02Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9501/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9501/

tchaikov · 2015-11-24T15:59:24Z

lgtm with qa run.

liewegas · 2015-11-24T16:11:56Z

lots of failures like this:

2015-11-24T07:13:26.438 INFO:tasks.ceph.osd.0.burnupi34.stderr:2015-11-24 07:13:26.435286 7fcf38a5f700 -1 osd.0 pg_epoch: 174 pg[1.1( v 132'41 (0'0,132'41] local-les=166 n=1 ec=8 les/c/f 166/166/0 165/165/50) [0,4] r=0 lpr=165 crt=116'37 lcod 128'39 mlcod 128'39 act
ive+clean NIBBLEWISE] process_copy_chunk omap digest 0xffffffff != source 0x0
2015-11-24T07:13:26.438 INFO:tasks.ceph.osd.0.burnupi34.stderr:2015-11-24 07:13:26.435313 7fcf38a5f700 -1 log_channel(cluster) log [ERR] : 1.1 copy from 1/9d6feb16/burnupi3420652-49/head to 1/67141e41/burnupi3420652-47/head omap digest 0xffffffff != source 0x0

liewegas · 2015-11-24T16:12:17Z

please run through some rados/thrash jobs via teuthology-openstack. thanks!

loic-bot · 2015-11-24T18:54:11Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9522/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9522/

loic-bot · 2015-11-24T19:16:30Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9523/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9523/

loic-bot · 2015-11-24T19:58:03Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9525/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9525/

loic-bot · 2015-11-24T23:27:57Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9529/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9529/

liewegas · 2015-11-28T16:39:49Z

needs rebase?

loic-bot · 2015-12-01T02:35:46Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9700/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9700/

loic-bot · 2015-12-05T04:20:57Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9866/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/9866/

dzafman · 2015-12-08T18:08:32Z

src/osd/ECBackend.cc

@@ -2091,7 +2091,24 @@ void ECBackend::be_deep_scrub(
    return;
  }

-  ECUtil::HashInfoRef hinfo = get_hash_info(poid, false);
+  //copy from get_hash_info. Because we already got xattrs, so it don't need


I'm having second thoughts on this change. Does the performance of scrub really matter that much to complicate this code? If so, we should modify get_hash_info() to take optional xattrs so it can use that if needed and available?

loic-bot · 2015-12-11T07:37:19Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/10074/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/10074/

loic-bot · 2015-12-15T21:54:35Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/10217/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/10217/

dzafman · 2015-12-21T21:15:24Z

This passed 98 out of 107 rados suite tests. The failures look like infrastructure issues.

dzafman · 2015-12-21T21:16:03Z

Reverted commits and fixes are removed and/or squashed.

dzafman · 2015-12-23T00:13:26Z

Per a pervious suggestion from Sage I'm going to do a rados/thrash run. Although I do recall that I fixed the cause of the omap digest inconsistency that was seen.

dzafman · 2015-12-23T06:36:18Z

Merge ceph-qa-suite "repair_test: Add whitelist item for new stat error message # 775" BEFORE merging this one.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

When set omapheader/omapvals, it alreade set FLAG_OMAP. So for remove don't set again. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

The code already check object whether exist. So it don't need call touch. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

… omap. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

Signed-off-by: David Zafman <dzafman@redhat.com>

dzafman · 2016-01-04T23:23:39Z

Testing passed (12 infrastructure failures, 69 passed 81 total) rados/thrash, before rebase which caused one commit to go away because it was fixed already. No conflicts on rebase.

dzafman · 2016-01-04T23:25:47Z

@tchaikov ready to merge

I already merged the require ceph-qa-suite change that corresponds to this.

Omap small bugs adapted Reviewed-by: Kefu Chai <kchai@redhat.com>

dzafman mentioned this pull request Nov 20, 2015

Omap small bugs #6046

Closed

liewegas added bug-fix core needs-qa labels Nov 23, 2015

dzafman force-pushed the omap-small-bugs branch 2 times, most recently from 6221382 to 3289283 Compare November 23, 2015 19:32

dzafman changed the title ~~DNM: Rebase and fixes for #6046 Omap small bugs~~ Rebase and fixes for #6046 Omap small bugs Nov 23, 2015

dzafman changed the title ~~Rebase and fixes for #6046 Omap small bugs~~ Omap small bugs adapted Nov 23, 2015

liewegas added the wip-sage2-testing label Nov 23, 2015

dzafman added a commit to dzafman/ceph that referenced this pull request Nov 24, 2015

Add stat_erorr handling because of new pull request ceph#6669

778cb56

liewegas removed the wip-sage2-testing label Nov 24, 2015

dzafman added the wip-zafman-testing label Nov 24, 2015

dzafman force-pushed the omap-small-bugs branch from 5c473b9 to 2f4d3ed Compare December 1, 2015 01:34

dzafman force-pushed the omap-small-bugs branch from 2f4d3ed to 918c4f8 Compare December 5, 2015 02:43

dzafman reviewed Dec 8, 2015
View reviewed changes

dzafman changed the title ~~Omap small bugs adapted~~ DNM: Omap small bugs adapted Dec 11, 2015

dzafman force-pushed the omap-small-bugs branch from 49dba38 to 21b9aa8 Compare December 21, 2015 21:14

dzafman removed needs-qa wip-zafman-testing labels Dec 21, 2015

dzafman changed the title ~~DNM: Omap small bugs adapted~~ Omap small bugs adapted Dec 21, 2015

dzafman added needs-qa wip-zafman-testing labels Dec 23, 2015

majianpeng and others added 9 commits January 4, 2016 11:16

osd/ReplicatedPG: It should call clear_omap_digest.

ef263b3

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd/ReplicatedPG: for omapclear/omaprmkeys no neet set FLAG_OMAP.

1f93b55

When set omapheader/omapvals, it alreade set FLAG_OMAP. So for remove don't set again. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd/ReplicatedPG: For omapclear/omaprmkeys, no need call touch.

5e114a4

The code already check object whether exist. So it don't need call touch. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd/ReplicatedBackend: Don't forget reset_tp_timeout for first read.

2c2d5c7

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd/PGBackend: Don't change error type from DEEP_ERROR to SHALLOW_ERROR.

4a7f007

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd/ReplicatedPG: for copy_get get omap, firstly check ob whether has…

771c869

… omap. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd: Fix ScrubMap::object::decode version

5924c3e

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Add stat_error for regular scrub handling

ca81563

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Allow get_hash_info to use attrs map if available

5c999b1

Signed-off-by: David Zafman <dzafman@redhat.com>

dzafman force-pushed the omap-small-bugs branch from 21b9aa8 to 5c999b1 Compare January 4, 2016 19:21

dzafman removed needs-qa wip-zafman-testing labels Jan 4, 2016

tchaikov added a commit that referenced this pull request Jan 5, 2016

Merge pull request #6669 from dzafman/omap-small-bugs

4d91de8

Omap small bugs adapted Reviewed-by: Kefu Chai <kchai@redhat.com>

tchaikov merged commit 4d91de8 into ceph:master Jan 5, 2016

dzafman deleted the omap-small-bugs branch January 5, 2016 01:47

ghost changed the title ~~Omap small bugs adapted~~ osd: Omap small bugs adapted Feb 10, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

osd: Omap small bugs adapted #6669

osd: Omap small bugs adapted #6669

dzafman commented Nov 20, 2015

loic-bot commented Nov 21, 2015

ghost commented Nov 21, 2015

dzafman commented Nov 23, 2015

loic-bot commented Nov 23, 2015

tchaikov commented Nov 24, 2015

liewegas commented Nov 24, 2015

liewegas commented Nov 24, 2015

loic-bot commented Nov 24, 2015

loic-bot commented Nov 24, 2015

loic-bot commented Nov 24, 2015

loic-bot commented Nov 24, 2015

liewegas commented Nov 28, 2015

loic-bot commented Dec 1, 2015

loic-bot commented Dec 5, 2015

dzafman Dec 8, 2015

loic-bot commented Dec 11, 2015

loic-bot commented Dec 15, 2015

dzafman commented Dec 21, 2015

dzafman commented Dec 21, 2015

dzafman commented Dec 23, 2015

dzafman commented Dec 23, 2015

dzafman commented Jan 4, 2016

dzafman commented Jan 4, 2016

osd: Omap small bugs adapted #6669

osd: Omap small bugs adapted #6669

Conversation

dzafman commented Nov 20, 2015

loic-bot commented Nov 21, 2015

ghost commented Nov 21, 2015

dzafman commented Nov 23, 2015

loic-bot commented Nov 23, 2015

tchaikov commented Nov 24, 2015

liewegas commented Nov 24, 2015

liewegas commented Nov 24, 2015

loic-bot commented Nov 24, 2015

loic-bot commented Nov 24, 2015

loic-bot commented Nov 24, 2015

loic-bot commented Nov 24, 2015

liewegas commented Nov 28, 2015

loic-bot commented Dec 1, 2015

loic-bot commented Dec 5, 2015

dzafman Dec 8, 2015

Choose a reason for hiding this comment

loic-bot commented Dec 11, 2015

loic-bot commented Dec 15, 2015

dzafman commented Dec 21, 2015

dzafman commented Dec 21, 2015

dzafman commented Dec 23, 2015

dzafman commented Dec 23, 2015

dzafman commented Jan 4, 2016

dzafman commented Jan 4, 2016