osd,mon: log leveldb and rocksdb to ceph log #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Write an entry to the log file with the specified format. | ||
| void Logv(const char* format, va_list ap) { | ||
| dout(1); | ||
| char buf[1048576]; |
There was a problem hiding this comment.
Hmm, I would like to think 1M is a dangerous value to stack size? AFAR, some OS may only have several hundreds KB stack size.
Maybe we can declare a 1k buf, then try to iterate the whole line. If failed, turn to heap allocation? Or just truncate the log line.
There was a problem hiding this comment.
yeah, dropped it to 64k. i did that trying to track down another bug but
it wasn't really needed.
Signed-off-by: Sage Weil <sage@redhat.com>
This greatly eases debugging, and avoids the unbounded growth of the leveldb LOG file. Signed-off-by: Sage Weil <sage@redhat.com>
|
the build failure is not relevant and is being addressed by #6927. |
|
tested locally, the log printed by leveldb looks like: lgtm |
liewegas
added a commit
that referenced
this pull request
Dec 19, 2015
osd,mon: log leveldb and rocksdb to ceph log Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much more convenient, and also avoids the LOG file growth/rotation
issue.`