Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: misc FileStore fixes #7059

Merged
merged 6 commits into from Jan 11, 2016
Merged

osd: misc FileStore fixes #7059

merged 6 commits into from Jan 11, 2016

Conversation

xiexingguo
Copy link
Member

Shall return a negative error code instead.

Fixes: #14187
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@liewegas
Copy link
Member

liewegas commented Jan 3, 2016

please rebase?

Shall return a negative error code instead.

Fixes: ceph#14187
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Shall return a negative return code instead, otherwise caller will unable to handle it.

Fixes: ceph#14194
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Fixes: ceph#14188
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo xiexingguo force-pushed the xxg-wip-14187 branch 3 times, most recently from 989bf27 to fa2bbfa Compare January 4, 2016 05:37
@xiexingguo xiexingguo mentioned this pull request Jan 4, 2016
Fixes: ceph#14186
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
Copy link
Member Author

@liewegas Rebased and some more small fixes, please review.

@liewegas
Copy link
Member

liewegas commented Jan 4, 2016

lgtm!

@xiexingguo xiexingguo force-pushed the xxg-wip-14187 branch 2 times, most recently from a045abf to 2334e5d Compare January 5, 2016 02:48
Although currently lfn_close() is a noop, but these cases will be problematic if someday
we want to do some real tidy up work.

Fixes: ceph#14192
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas added a commit that referenced this pull request Jan 11, 2016
osd: misc FileStore fixes

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit e7ee4f3 into ceph:master Jan 11, 2016
@xiexingguo xiexingguo deleted the xxg-wip-14187 branch January 11, 2016 23:39
@ghost ghost changed the title os: fix return code if unable to sync osd: misc FileStore fixes Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants