Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: make list_missing query missing_loc.needs_recovery_map #6298

Merged
merged 2 commits into from Dec 23, 2015
Merged

osd: make list_missing query missing_loc.needs_recovery_map #6298

merged 2 commits into from Dec 23, 2015

Conversation

guangyy
Copy link
Contributor

@guangyy guangyy commented Oct 16, 2015

Fixes: 13441
Signed-off-by: Guang Yang yguang@yahoo-inc.com

@guangyy
Copy link
Contributor Author

guangyy commented Oct 16, 2015

Manual testings looks good, working on automation.

@ghost ghost added the core label Oct 19, 2015
@guangyy guangyy changed the title [DNM] osd: list_missing should query missing_loc.needs_recovery_map osd: list_missing should query missing_loc.needs_recovery_map Oct 19, 2015
@guangyy
Copy link
Contributor Author

guangyy commented Oct 19, 2015

Hi @athanatos , this is ready for review.

One thing that is missing is a test case for unfound objects in replicated pool, I didn't figure out a way to do it easily. (I tried to remove all three copies from file system and then did a repair of the PG, it did not show unfound object, I guess that is another bug).

@guangyy
Copy link
Contributor Author

guangyy commented Oct 20, 2015

@dachary , the bot failure seems unrelated to the changes in this PR, is it a known pattern?

@ghost
Copy link

ghost commented Oct 20, 2015

@guangyy I saw this false negative once yesterday but could not figure it out. Could you please rebase and repush to verify it goes away ? Thanks for letting me know :-)

Guang Yang added 2 commits October 20, 2015 15:30
Fixes: 13441
Signed-off-by: Guang Yang <yguang@yahoo-inc.com>
Signed-off-by: Guang Yang <yguang@yahoo-inc.com>
@guangyy
Copy link
Contributor Author

guangyy commented Oct 20, 2015

Thanks @dachary , rebased and repushed, let us see the check this time :)

@guangyy
Copy link
Contributor Author

guangyy commented Oct 21, 2015

Ping @athanatos :)

@guangyy guangyy changed the title osd: list_missing should query missing_loc.needs_recovery_map [DNM] osd: list_missing should query missing_loc.needs_recovery_map Oct 22, 2015
@guangyy
Copy link
Contributor Author

guangyy commented Oct 22, 2015

As discussed with @athanatos , we will add a test case into ceph-qa-suite for this.

@guangyy
Copy link
Contributor Author

guangyy commented Oct 27, 2015

Hi @athanatos ,
If the code looks good, could you help to push it to ceph's repository, so that I can run some teuthology test? Thanks!

@liewegas
Copy link
Member

@guangyy I've added you to the ceph project, so you can push wip- branches. Be careful not to touch the main ones!

Alternatively, you can use teuthology-openstack, which does its own local builds and doesn't rely on any upstream access.

@ghost
Copy link

ghost commented Nov 24, 2015

@guangyy for your convenience, here is the command line you need to run the test:

teuthology-openstack --verbose --key-name myself --key-filename ~/Downloads/myself --suite rados/thrash --ceph-qa-suite-git-url https://github.com/ceph/ceph-qa-suite.git --suite-branch ceph --ceph-git-url https://github.com/guangyy/ceph.git --ceph wip-13441 --subset 2/3

to verify that teuthology-openstack works for you, please follow the instructions at https://github.com/dachary/teuthology/tree/openstack#openstack-backend

Let me know if you need help.

@guangyy
Copy link
Contributor Author

guangyy commented Nov 26, 2015

Thanks @liewegas @dachary , I will give it a try.

@guangyy
Copy link
Contributor Author

guangyy commented Dec 5, 2015

Newly added ceph-qa-suite passed, ready for review and merge.

Test case: ceph/ceph-qa-suite#755
Job:
http://qa-proxy.ceph.com/teuthology/yguang-2015-12-04_17:18:17-rados-wip-13441---basic-multi/1167683/teuthology.log

@guangyy guangyy changed the title [DNM] osd: list_missing should query missing_loc.needs_recovery_map osd: list_missing should query missing_loc.needs_recovery_map Dec 5, 2015
@guangyy
Copy link
Contributor Author

guangyy commented Dec 5, 2015

@athanatos .

@guangyy guangyy added the bug-fix label Dec 5, 2015
@athanatos
Copy link
Contributor

lgtm, does it still need a full suite run?

@guangyy
Copy link
Contributor Author

guangyy commented Dec 10, 2015

Thanks @athanatos , yeah I think it would be helpful to run along with a full suite.

liewegas added a commit that referenced this pull request Dec 23, 2015
osd: make list_missing query missing_loc.needs_recovery_map

Reviewed-by: Samuel Just <sjust@redhat.com>
@liewegas liewegas merged commit 459f2e8 into ceph:master Dec 23, 2015
@ghost ghost changed the title osd: list_missing should query missing_loc.needs_recovery_map osd: make list_missing query missing_loc.needs_recovery_map Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants