New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: make list_missing query missing_loc.needs_recovery_map #6298
Conversation
Manual testings looks good, working on automation. |
Hi @athanatos , this is ready for review. One thing that is missing is a test case for unfound objects in replicated pool, I didn't figure out a way to do it easily. (I tried to remove all three copies from file system and then did a repair of the PG, it did not show unfound object, I guess that is another bug). |
@dachary , the bot failure seems unrelated to the changes in this PR, is it a known pattern? |
@guangyy I saw this false negative once yesterday but could not figure it out. Could you please rebase and repush to verify it goes away ? Thanks for letting me know :-) |
Fixes: 13441 Signed-off-by: Guang Yang <yguang@yahoo-inc.com>
Signed-off-by: Guang Yang <yguang@yahoo-inc.com>
Thanks @dachary , rebased and repushed, let us see the check this time :) |
Ping @athanatos :) |
As discussed with @athanatos , we will add a test case into ceph-qa-suite for this. |
Hi @athanatos , |
@guangyy I've added you to the ceph project, so you can push wip- branches. Be careful not to touch the main ones! Alternatively, you can use teuthology-openstack, which does its own local builds and doesn't rely on any upstream access. |
@guangyy for your convenience, here is the command line you need to run the test: teuthology-openstack --verbose --key-name myself --key-filename ~/Downloads/myself --suite rados/thrash --ceph-qa-suite-git-url https://github.com/ceph/ceph-qa-suite.git --suite-branch ceph --ceph-git-url https://github.com/guangyy/ceph.git --ceph wip-13441 --subset 2/3 to verify that teuthology-openstack works for you, please follow the instructions at https://github.com/dachary/teuthology/tree/openstack#openstack-backend Let me know if you need help. |
Newly added ceph-qa-suite passed, ready for review and merge. Test case: ceph/ceph-qa-suite#755 |
lgtm, does it still need a full suite run? |
Thanks @athanatos , yeah I think it would be helpful to run along with a full suite. |
osd: make list_missing query missing_loc.needs_recovery_map Reviewed-by: Samuel Just <sjust@redhat.com>
Fixes: 13441
Signed-off-by: Guang Yang yguang@yahoo-inc.com