osd: fix wrongly placed assert and some cleanups #6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's too late to catch this fatal error. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
ghost
self-assigned this
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
Append last_fresh time at the end of the output message. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
These two statements do not needed anymore Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xiexingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-cleanup
branch
from
ee932c9
to
b89179a
Compare
|
@dachary Some more cleanups, please review. |
|
@XinzeChi Fixed, thank you for your reminder. |
|
please squash into one commit. |
|
@yuyuyu101 All of them? I'd like them to stay this way as it is far more clear for tracing purpose. @dachary What do you think? |
|
@xiexingguo @dachary @yuyuyu101 The 4 commits are independent changes, so looks good to me. My 2 cents. |
|
@yuyuyu101 I tend to agree with @dzafman. Did you have a specific reason in mind when you suggested the squash ? |
|
I'm just fine if remaining unchanged. |
|
@yuyuyu101 cool, thanks for the confirmation :-) |
|
@xiexingguo once it passes a qa run, it's good to merge IMHO. Reviewed-by: Loic Dachary <ldachary@redhat.com> |
liewegas
added a commit
that referenced
this pull request
Dec 19, 2015
osd: fix wrongly placed assert and some cleanups Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.