New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: fix wrongly placed assert and some cleanups #6766
Conversation
It's too late to catch this fatal error. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
Append last_fresh time at the end of the output message. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
These two statements do not needed anymore Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xiexingguo <xie.xingguo@zte.com.cn>
ee932c9
to
b89179a
Compare
@dachary Some more cleanups, please review. |
@XinzeChi Fixed, thank you for your reminder. |
please squash into one commit. |
@yuyuyu101 All of them? I'd like them to stay this way as it is far more clear for tracing purpose. @dachary What do you think? |
@xiexingguo @dachary @yuyuyu101 The 4 commits are independent changes, so looks good to me. My 2 cents. |
@yuyuyu101 I tend to agree with @dzafman. Did you have a specific reason in mind when you suggested the squash ? |
I'm just fine if remaining unchanged. |
@yuyuyu101 cool, thanks for the confirmation :-) |
@xiexingguo once it passes a qa run, it's good to merge IMHO. Reviewed-by: Loic Dachary <ldachary@redhat.com> |
osd: fix wrongly placed assert and some cleanups Reviewed-by: Loic Dachary <ldachary@redhat.com>
No description provided.