osd: fix null pointer access and race condition #6916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-14072
branch
from
dd1eb81
to
d914448
Compare
We are risking of accessing a null osdmap pointer when we failed to handle an osdmap message due to network error. Also, it is not safe to change failure_pending without protection of hearbeat_lock. Fixes: ceph#14072 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@tchaikov Ping~~ |
|
lgtm with qa run. |
Closed
liewegas
added a commit
that referenced
this pull request
Jan 3, 2016
osd: fix null pointer access and race condition Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are risking of accessing a null osdmap pointer when we failed to handle an osdmap message due to network error.
Also, it is not safe to change failure_pending without protection of hearbeat_lock.
Fixes:#14072
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn