osd: do not keep ref of old osdmap in pg #7007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not hold a strong reference to last_persisted_osdmap in PG. as
an OSD tries to trim previously persisted osdmaps, if they are
not referenced anymore. this helps to keep the meta collection
in a manageable size. if we advance the osdmap many times, and
some PGs are not impacted by these changes, it's very likely that
they are still holding very old osdmap references in their
last_persisted_osdmap_ref
. this practically prevents the OSDfrom removing the out-dated osdmap in OSD::handle_osd_map(). so,
instead of holding a reference of last_persisted_osdmap, we can
simply remember its epoch.
Fixes: #13990
Signed-off-by: Kefu Chai kchai@redhat.com