osd: bluestore: more fixes #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -464,6 +487,37 @@ int BlockDevice::read(uint64_t off, uint64_t len, bufferlist *pbl, | |||
| return r < 0 ? r : 0; | |||
| } | |||
|
|
|||
| int BlockDevice::read_buffered(uint64_t off, uint64_t len, char *buf) | |||
There was a problem hiding this comment.
what's the difference with BlockDevice::read(off, len, pbl, NULL, true)?
There was a problem hiding this comment.
This doesn't enforce block-alignment, it is always buffered (uses page
cache), and it doesn't allocate any memory. This is the path taken by
rocksdb when reading small bits of the sst files (which it doesn't
explicitly cache--it relies on the page cache).
liewegas
force-pushed
the
wip-bluestore
branch
2 times, most recently
from
2763dde
to
9fde446
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Doing it in the aio thread ensures that there isn't a use-after-free. Note that this is only bluefs written files. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Wait on fsync and _flush_log only. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
fdatasync(2) does a cache flush on the device, which we want to avoid if we didn't actually write anything. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
These are on my todo list elsewhere. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
The object may have trailing zeros. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
If we're past EOF, we need to zero the rest of the block. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore
branch
from
3bdc89a
to
8480ede
Compare
Prefill the objectstore by fragmenting the freespace. Max free allocations are bluestore_debug_prefragment_max bytes (default 1M). Prefill defaults to 0, of course. One would normally just set this to .8 to get something resembling an aged disk. Signed-off-by: Sage Weil <sage@redhat.com>
- drop the MIN cruft - unreserve what we didn't get Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore
branch
from
c3d50c2
to
a87470e
Compare
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.