Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: bluestore: fix space rebalancing, collection split, buffered reads #7196

Merged
merged 11 commits into from Jan 14, 2016

Conversation

liewegas
Copy link
Member

No description provided.

Simplify config, and avoid immediate gift or reclaim when it doesn't match.

Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
- simplify tunables (min/max ratio of freespace between bluefs vs bluestore)
- add reclaim support

Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas liewegas changed the title bluestore: fix space rebalancing bluestore: fix space rebalancing, collection split Jan 11, 2016
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Readahead can break our mix of aio/dio and buffered io.  Although the
dio path will invalidate pages before and after initiating the IO, and we
do not issue racing buffered reads, the readahead code might.  That would
result in pages in the page cache that are not coherent with an aio write.

This is easy to reproduce with ceph_test_objectstore's Synthetic case
when bluestore_default_buffered_read=true.

Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas added a commit that referenced this pull request Jan 14, 2016
osd: bluestore: fix space rebalancing, collection split, buffered reads
@liewegas liewegas merged commit 7241bf3 into ceph:master Jan 14, 2016
@liewegas liewegas deleted the wip-bluestore branch January 14, 2016 23:58
@ghost ghost changed the title bluestore: fix space rebalancing, collection split osd: bluestore: fix space rebalancing, collection split, buffered reads Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant