os/bluestore: fix bluestore_wal_transaction_t encoding test #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
bluestore_wal_op_t::op is encoded/dumped but it is not initialized in its ctor. so set it to 0 in its ctor. 0 is not an valid op though, but it helps with debugging and testing. Signed-off-by: Kefu Chai <kchai@redhat.com> Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-enconding-error-jewel
branch
from
97f68b9
to
b0c2bcf
Compare
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Jan 29, 2016
os/bluestore: fix bluestore_wal_transaction_t encoding test Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bluestore_wal_op_t::op is encoded/dumped but it is not
initialized in its ctor. so set it to 0 in its ctor. 0 is not an
valid op though, but it helps with debugging and testing.
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 4d30e7c)
Signed-off-by: Brad Hubbard bhubbard@redhat.com
Need to backport this for tests to pass on Jewel