objecter: avoid recursive lock of Objecter::rwlock #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objecter::RequestStateHook::call() already takes read lock of Objecter::rwlock. Taking read lock again in Objecter::_dump_foo_ops() can trigger lockdep assertion. Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
This is probably of interest to @athanatos and @jdurgin. It looks good to me in a brief glance, though — these functions are only invoked in dump_requests, which is only invoked in Objecter::RequestStateHook::call. It wouldn't crash without lockdep since read locks are inherently recursive. |
|
trivially correct, accidentally introduced in the large objecter locking refactor |
jdurgin
added a commit
that referenced
this pull request
Jan 26, 2016
objecter: avoid recursive lock of Objecter::rwlock Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objecter::RequestStateHook::call() already takes read lock of
Objecter::rwlock. Taking read lock again in Objecter::_dump_foo_ops()
can trigger lockdep assertion.
Signed-off-by: Yan, Zheng zyan@redhat.com