mon: PGMonitor: acting primary diff with cur_stat, should not set pg to stale #7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov yeah, if acting_primary changed, then the old primary down should not affect the pg_stat_updates, and exactly last_unstale should not change too, thanks ! |
|
@cxwshawn you are right, it makes sense to me. could you squash these two commit into a single one? |
…ale. Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
cxwshawn
force-pushed
the
wip-pg_stat-fix
branch
from
8153f82
to
beb99d7
Compare
|
@tchaikov sorry for the latency, fixed, please review, thanks. |
|
lgtm with rados qa run. |
liewegas
added a commit
that referenced
this pull request
Jan 11, 2016
mon: PGMonitor: acting primary diff with cur_stat, should not set pg to stale Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiaowei Chen chen.xiaowei@h3c.com