Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon/PGMap: show rd/wr iops separately in status reports #7072

Merged
merged 1 commit into from Jan 11, 2016
Merged

mon/PGMap: show rd/wr iops separately in status reports #7072

merged 1 commit into from Jan 11, 2016

Conversation

dllgzcl
Copy link
Contributor

@dllgzcl dllgzcl commented Dec 29, 2015

When check the iops, we always do not focuns on the total iops, but read iops and write iops. So the iops should be showed separately.

@dllgzcl
Copy link
Contributor Author

dllgzcl commented Dec 29, 2015

Please take a look and merge it !

@tchaikov
Copy link
Contributor

@dllgzcl could you revise the title of your commit message, so that it is more specific?

ceph: modify the iops with read iops and write iops

could be something like:

mon/PGMap: show rd/wr iops separately in status reports

@dllgzcl
mon/PGMap: show rd/wr iops separately in status reports
c01a314 
When check the iops, we always do not focuns on the total iops, but read iops and write iops. So the iops should be showed separately.

Signed-off-by: Cilang Zhao <zhao.cilang@h3c.com>
@dllgzcl
Copy link
Contributor Author

dllgzcl commented Dec 31, 2015

I have revised the commit, would you take a look?@tchaikov

@dllgzcl
Copy link
Contributor Author

dllgzcl commented Jan 4, 2016

Please take a look?@tchaikov

@tchaikov
Copy link
Contributor

tchaikov commented Jan 4, 2016

lgtm.

@dllgzcl
Copy link
Contributor Author

dllgzcl commented Jan 4, 2016

Would you merge it? ^.^ @tchaikov

@tchaikov tchaikov changed the title Wip zcl ceph s mon/PGMap: show rd/wr iops separately in status reports Jan 5, 2016
@dllgzcl
Copy link
Contributor Author

dllgzcl commented Jan 7, 2016

Would you merge it? :) @tchaikov

@dllgzcl
Copy link
Contributor Author

dllgzcl commented Jan 11, 2016

Hello! Would you take a look? @tchaikov ^.^

@tchaikov
Copy link
Contributor

tested locally by running,

$ rados -p rbd bench --no-cleanup 1 write -b 4096 &
$ ceph osd pool stats rbd --format=json-pretty
[
    {
        "pool_name": "rbd",
        "pool_id": 0,
        "recovery": {},
        "recovery_rate": {},
        "client_io_rate": {
            "write_bytes_sec": 60160,
            "read_op_per_sec": 0,
            "write_op_per_sec": 14
        }
    }
]

$ ceph osd pool stats rbd
pool rbd id 0
  client io 0 B/s wr, 0 op/s rd, 0 op/s wr

@tchaikov tchaikov self-assigned this Jan 11, 2016
tchaikov added a commit that referenced this pull request Jan 11, 2016
@tchaikov
Merge pull request #7072 from dllgzcl/wip-zcl-ceph-s
0bb7054 
mon/PGMap: show rd/wr iops separately in status reports

Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit 0bb7054 into ceph:master Jan 11, 2016
@dllgzcl
Copy link
Contributor Author

dllgzcl commented Jan 11, 2016

3Q @tchaikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tchaikov tchaikov

Labels
core feature
Projects
None yet
Milestone
No milestone
2 participants
@dllgzcl @tchaikov