Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: paxos is_recovering calc error #7227

Merged
merged 1 commit into from Jan 14, 2016
Merged

mon: paxos is_recovering calc error #7227

merged 1 commit into from Jan 14, 2016

Conversation

dwj192
Copy link
Contributor

@dwj192 dwj192 commented Jan 14, 2016

Fix:#14368

Signed-off-by: Weijun Duan duanweijun@h3c.com

Fix:ceph#14368

Signed-off-by: Weijun Duan <duanweijun@h3c.com>
@tchaikov
Copy link
Contributor

@dwj192 better off putting "Fixes: #14368", and place this line right before your signed-off-by label.

lgtm

@jecluis
Copy link
Member

jecluis commented Jan 14, 2016

I'm okay with this commit, mostly because it seems this function is not currently used.

@jecluis
Copy link
Member

jecluis commented Jan 14, 2016

Also, I don't think this needs qa. That would just waste resources. @tchaikov please confirm this by running a git grep -ni 'is_recovering(' src/ in case I'm missing something ;)

@tchaikov
Copy link
Contributor

ahh, my fault. confirmed.

@tchaikov tchaikov added cleanup and removed needs-qa labels Jan 14, 2016
tchaikov added a commit that referenced this pull request Jan 14, 2016
mon: paxos is_recovering calc error

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit fd305c8 into ceph:master Jan 14, 2016
@dwj192 dwj192 deleted the dwj-paxos branch January 15, 2016 04:02
@ghost ghost added the core label Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants