mon/MDSMonitor: add confirmation to "ceph mds rmfailed" #7248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, but would be nice to have this being tested by the cephtool workunit. |
| string confirm; | ||
| if (!cmd_getval(g_ceph_context, cmdmap, "confirm", confirm) || | ||
| confirm != "--yes-i-really-mean-it") { | ||
| ss << "WARNING: this will cause failover mechanism to stop working. " |
There was a problem hiding this comment.
We should make this message more severe.
Maybe "WARNING: this can make your filesystem inaccessible, use extreme caution!"
|
While we're making changes we should add the checks and warnings to any other commands which deserve them — like the recently demonstrated setmap command. ;) |
gregsfortytwo
added a commit
that referenced
this pull request
Jan 18, 2016
…-fs-testing #7248 Reviewed-by: Joao Eduardo Luis <joao@suse.de> Reviewed-by: Greg Farnum <gfarnum@redhat.com>
gregsfortytwo
added a commit
that referenced
this pull request
Jan 19, 2016
…-fs-testing #7248 Reviewed-by: Joao Eduardo Luis <joao@suse.de> Reviewed-by: Greg Farnum <gfarnum@redhat.com>
|
My testing branch is failing make check with "FAIL: test/pybind/test_ceph_argparse.py", and I presume it's because this PR or #7262 got broken somehow. |
Fixes: ceph#14379 Signed-off-by: Yan, Zheng <zyan@redhat.com>
bluestore_wal_transaction_t /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 differ: byte 60, line 5 **** bluestore_wal_transaction_t test 2 dump_json check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 dump_json > /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 encode decode dump_json > /tmp/typ-eV5I52Jt8 diff /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 /tmp/typ-ybpvQW9mL /tmp/typ-3q8FRszW0 differ: byte 61, line 5 **** bluestore_wal_transaction_t test 2 copy dump_json check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 dump_json > /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 copy dump_json > /tmp/typ-eV5I52Jt8 diff /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 /tmp/typ-ybpvQW9mL /tmp/typ-ptIzfCk06 differ: byte 60, line 5 **** bluestore_wal_transaction_t test 2 copy_ctor dump_json check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 dump_json > /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 copy_ctor dump_json > /tmp/typ-eV5I52Jt8 diff /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 differ: byte 25, line 1 **** bluestore_wal_transaction_t test 2 binary reencode check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 encode export /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 encode decode encode export /tmp/typ-eV5I52Jt8 cmp /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 the failure of 'make check' should not be related to this change |
|
I know the bluestore encode failures are unrelated, but there are also failures in ceph_test_argparse around the commands being changed in this and the companion PR. |
|
ceph_test_argparse failure has already been fixed |
liewegas
added a commit
that referenced
this pull request
Jan 29, 2016
mon/MDSMonitor: add confirmation to "ceph mds rmfailed" Reviewed-by: Joao Eduardo Luis <joao@suse.de>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14379
Signed-off-by: Yan, Zheng zyan@redhat.com