mon: fix the can't change subscribe level bug in monitoring log #7031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm with a nit. @jecluis do you mind reviewing it also? thanks. |
wonzhq
force-pushed
the
log-monitor-2
branch
from
1848f87
to
9af4d56
Compare
|
@tchaikov updated, thx for taking a look. |
For monitoring log, when changing between different levels, should remove previous level in the subscribes. This is because unlike other PaxosServices, LogMonitor has multiple subscription names/types and they are log levels, and hence mutual exclusive. when setting a new subscription for logmon, we need to remove the old log level if any. Signed-off-by: Zhiqiang Wang <wonzhq@hotmail.com>
Signed-off-by: Zhiqiang Wang <wonzhq@hotmail.com>
This test doesn't pass previously because of a bug. After fixing it, we can now enable this test. Signed-off-by: Zhiqiang Wang <wonzhq@hotmail.com>
|
lgtm. |
liewegas
added a commit
that referenced
this pull request
Jan 3, 2016
mon: fix the can't change subscribe level bug in monitoring log Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.