mon: fix reuse of osd ids (clear osd info on osd deletion) #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an OSD id is removed via ceph osd rm, it will be reused by the next ceph osd create command. Verify that and OSD reusing such an id successfully comes up. http://tracker.ceph.com/issues/13988 Refs: ceph#13988 Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
self-assigned this
|
pg_temp is not osd-based, and the mon cleans it up. yes on primary affinity. same for state. repushing! |
If we destroy an OSD in the map, clear not just the uuid but also all the metadata about it. Specifically, we care about up_from, which can prevent a new OSD from booting if it starts with a map prior to the deletion when it sends it boot. Specifically, the osd epoch may be 0 and if the latest osd epoch is also small the osd decide it is "close enough" to the latest epoch and sends the boot message. In practice this problem wouldn't surface on any cluster that isn't brand new. Note that this changes the result of applying an incremental. As such, it will cause lots of old OSDs to request full maps from the mon, spiking load during an upgrade. This is as it should be. Fixes: ceph#13988 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-13988
branch
2 times, most recently
from
5ae5e0d
to
4e28f9e
Compare
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
|
Running the ceph-disk suite which hits the bug every time on master teuthology-openstack --verbose --key-filename ~/Downloads/myself --key-name myself --teuthology-git-url http://github.com/dachary/teuthology --teuthology-branch wip-suite --ceph-qa-suite-git-url http://github.com/ceph/ceph-qa-suite --suite-branch master --ceph-git-url http://github.com/liewegas/ceph --ceph wip-13988 --suite ceph-disk --filter ubuntu_14.04 |
|
@liewegas could you update the commit message regarding the upgrade ? Since it has no influence on anything user visible, I assume the merge commit can be empty and not be highlighted in the release notes. |
|
@liewegas the bot failure is from http://tracker.ceph.com/issues/13986 and should be ignored. |
liewegas
added a commit
that referenced
this pull request
Dec 18, 2015
mon: fix reuse of osd ids (clear osd info on osd deletion) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13988