mon: degrade a log message to level 2 #6929
Conversation
FIX ceph#14083 When leader election was done successfully, it will ask peon to collect info. When failed, it will cause monitor to do reelection, which makes relevant log message so important. So It would be better if reducing the log level from 5 to 2. Signed-off-by: Kongming Wu <wu.kongming@h3c.com>
ghost
added
|
I think logging this at level 0 may cause unnecessary panic, especially given this is normal behavior. Logging it at level 1 would be better than logging at level 0. That way you can simply set 'debug paxos = 1' to catch it, without having the noise from other messages from higher levels (such as 5). Other users will likely not care about this as long as the monitors join the quorum at some point; if they do, they too can set 'debug paxos = 1' to catch it. |
|
@jecluis OK! That sounds sensible. I've done updating. |
clever215
changed the title
|
@clever215 I know this is annoying, but I just realized the default log level for paxos is '1'. And that's likely why this is set to '5' to begin with. I'd ask you to bear with me and set '2' instead of '1'. The reasoning is the same I gave before. Sorry about that! |
|
@jecluis I just discussed with my colleague, and she said it will not product this log message so many times if monitor election is running without error. Only DB broken that she happened, and She found this log message is convenient to locate issue. But what you said is also reasonable. |
|
What your colleague is seeing is not because the store is broken. Most likely, the store being "broken" is enhancing the reasons why this happens (slow monitor, falling behind etc). If you want to easily reproduce this state, you just have to keep a monitor out of quorum for long enough that, by the time it tries to join, the state has advanced enough that you do not share any paxos versions. IIRC, this will happen whenever a new monitor is joining the quorum, for instance. |
clever215
changed the title
|
@jecluis Yes, you are right! |
mon: degrade a log message to level 2 Reviewed-by: Joao Eduardo Luis <joao@suse.de>
FIX #14083
When leader election was done successfully, it will ask peon to collect info. When failed, it will cause monitor to do reelection, which makes relevant log message so important.
So It would be better if reducing the log level to a default value.
Signed-off-by: Kongming Wu wu.kongming@h3c.com