librbd: small fixes for error messages and readahead counter #6983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
changed the title
| @@ -256,6 +256,7 @@ int validate_pool(IoCtx &io_ctx, CephContext *cct) { | |||
| if (r < 0) { | |||
| lderr(cct) << "failed to release self-managed snapshot " << snap_id | |||
| << ": " << cpp_strerror(r) << dendl; | |||
| return r; | |||
There was a problem hiding this comment.
Not returning the error result was intentional. There is no way to recover and delete the snapshot id ever again -- and the pool has already been changed to self-managed snapshot mode. Therefore, no need to abort the create request.
xiexingguo
force-pushed
the
xxg-wip-14126
branch
from
0d7a95e
to
ec5c070
Compare
Fixes: ceph#14127 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-14126
branch
from
ec5c070
to
4a4048b
Compare
As equivalent size is ok for copy. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
It's more human-readable. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@xiexingguo you can ignore the bot failure at http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/10346/, it is a known false negative ( see http://tracker.ceph.com/issues/14092 for details). |
|
@dillaman Please take a look at this one too, which is fixed as just you suggested, thanks! |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
jdurgin
added a commit
that referenced
this pull request
Dec 23, 2015
librbd: small fixes for error messages and readahead counter Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix http://tracker.ceph.com/issues/14127
And improve some tip messages.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn