librbd: journal replay should honor inter-event dependencies #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdurgin some light reading for the New Year 😉 |
|
"only" 7k lines changed |
|
@dachary looks like new Jenkin's slave needs more memory(?) |
|
@dillaman that would be a request for @alfredodeza or @andrewschoen. I don't know what kind of jenkins slaves are selected to run the bot. |
|
a bummer, yes, I think we need to tweak this for more memory |
|
lgtm once it runs through a rbd suite. |
|
I'll kick off a suite run tomorrow. |
added 18 commits
January 15, 2016 10:40
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
In general, the op shoud only start after the jouranl event is safely committed. Snapshot create and resize need special treatment to record the event while no IO is in-progress. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This will permit unit testing and will facilitate proper serialization of requests (when necessary). Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Properly track when AIO operations are safely committed to disk before marking the journal events are committed. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
added 8 commits
January 15, 2016 10:40
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
After snap create has blocked IO and after resize has ensured clipped IO boundaries, they will resume the playback of journal events. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Lots of environment noise, but no failures from these changes: http://pulpito.ceph.com/jdillaman-2016-01-13_17:39:05-rbd-wip-14006---basic-multi/ http://pulpito.ceph.com/jdillaman-2016-01-13_18:36:42-rbd-wip-14006---basic-multi/ |
jdurgin
added a commit
that referenced
this pull request
Jan 18, 2016
librbd: journal replay should honor inter-event dependencies Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIO write/discard operations are not marked as committed until safely flushed to disk (explicitly or automatically after enough unflushed events build-up in replay). Simple maintenance operations (ones that cannot affect IO operations) are delayed until after the OpFinish event is processed. Complex maintenance operations (which can affect IO) are partially executed until the point where internal state is consistent before journal event processing continues.