librbd: fix snap_exists API return code overflow #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-14129
branch
from
21a03e6
to
896160e
Compare
| @@ -206,7 +206,9 @@ class CEPH_RBD_API Image | |||
|
|
|||
| /* snapshots */ | |||
| int snap_list(std::vector<snap_info_t>& snaps); | |||
| /* DEPRECATED; use snap_exists2 */ | |||
There was a problem hiding this comment.
Would rather see __attribute__ ((deprecated)) appended to snap_exists.
xiexingguo
force-pushed
the
xxg-wip-14129
branch
from
896160e
to
5a481fb
Compare
The original one may overflow and thus not be safe. Fixes: ceph#14129 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@dillaman Fixed as you suggested, please review. Thanks a lot! |
|
Couple more spots that should be swapped over to |
|
@dillaman OK~~~, I'll try to find them out as soon as possible:) |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-14129
branch
from
b9fe651
to
6a45bbc
Compare
|
@dillaman Fixed, please review:) Thank you for your patience. |
dillaman
pushed a commit
that referenced
this pull request
Dec 21, 2015
librbd: fix snap_exists API return code overflow Reviewed-by: Jason Dillaman <dillaman@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14129