librbd: exit if parent's snap is gone during clone #6968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (r < 0) { | ||
| // we lost the race with snap removal? | ||
| lderr(cct) << "parent SnapInfo is gone" << dendl; |
There was a problem hiding this comment.
Users won't know what SnapInfo is -- suggest something like "unable to locate parent snapshot". Should also probably return -ENOENT instead of -EINVAL.
Fixes: ceph#14118 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-14118
branch
from
b04e1ba
to
395bf8a
Compare
jdurgin
added a commit
that referenced
this pull request
Dec 18, 2015
librbd: exit if parent's snap is gone during clone Reviewed-by: Jason Dillaman <dillaman@redhat.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.