librados: fix several flaws introduced by the enumeration_objects API #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we may risk of executing the callback twice, which is fatal. Fixes: ceph#14299 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Fixes: ceph#14300 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Fixes: ceph#14301 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-14299
branch
from
e2bc1ab
to
a753cef
Compare
|
The enumerate fixes look good to me |
|
These all look good except for the race condition fix. Can you drop that patch from this series? Instead, I think we should call the g_conf->should_gather(...) helper so that we can avoid taking the locks and calling the _dump* methods entirely if the log level is low. As things currently stand, we are iterating over all those maps even if nothing is logged/printed, which is a waste of CPU. Adding the proper locking is making that even more expensive. Thanks! |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-14299
branch
from
2ba799f
to
d6ce874
Compare
liewegas
added a commit
that referenced
this pull request
Jan 13, 2016
librados: fix several flaws introduced by the enumeration_objects API Reviewed-by: John Spray <jspray@redhat.com> Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.