doc: admin/build-doc: make paths absolute #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if [ ! -e $vdir ]; then | ||
| virtualenv --system-site-packages $vdir | ||
| fi | ||
| $vdir/bin/pip install --quiet -r ../admin/doc-requirements.txt | ||
| $vdir/bin/pip install --quiet -r $TOPDIR/admin/doc-requirements.txt | ||
|
|
||
| install -d -m0755 \ | ||
| output/html \ |
|
lgtm |
Build failure on docs.dhc because pip apparently was changing directory before building rbd with cython, causing the relative library path references to fail. Bite the bullet and make everything absolute (since we already have TOPDIR to use). Signed-off-by: Dan Mick <dan.mick@redhat.com>
jdurgin
added a commit
that referenced
this pull request
Jan 6, 2016
admin/build-doc: make paths absolute Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
This looks to have broken the centos7 gitbuilder, guys: http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-rpm-centos7-amd64-basic/log.cgi?log=7dc7c423bb7e7f2dfbce674187ee7863f27729b0 |
|
Actually, hmm, maybe something just didn't get set right for the first build. Stuff on top of the commit seems to be getting past that point (http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-rpm-centos7-amd64-basic/log.cgi?log=ca07d1db3edb9e59d485a3a5799c2ff9c13bcadf) so we may be good |
|
Thanks @dmick for fixing this |
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build failure on docs.dhc because pip apparently was changing directory
before building rbd with cython, causing the relative library path
references to fail. Bite the bullet and make everything absolute (since
we already have TOPDIR to use).
Signed-off-by: Dan Mick dan.mick@redhat.com