crush/CrushTester: check for overlapped rules #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we add a simple test for this? probably test/cli/crushtool/something.t ? |
list rules if there are more than one of them can be chosen by the CRUSH for a given ruleset, pool type and a pool size. this is not entirely a buggy crush map, but it might be worthy to get the attention of the user that multiple rules overlap with each other, and only the first one will be used by the CRUSH. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-check-for-overlapped-rule
branch
from
5d9bf8f
to
cf9cd80
Compare
|
@liewegas ahh, forgot to add them, done. |
liewegas
added a commit
that referenced
this pull request
Jan 13, 2016
crush/CrushTester: check for overlapped rules Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list rules if there are more than one of them can be chosen by the CRUSH
for a given ruleset, pool type and a pool size. this is not entirely a
buggy crush map, but it might be worthy to get the attention of the user
that multiple rules overlap with each other, and only the first one will
be used by the CRUSH.
Signed-off-by: Kefu Chai kchai@redhat.com